Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unused parameter warning messages from sections used at least once #2578

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Improve unused parameter warning messages from sections used at least once #2578

merged 2 commits into from
Aug 19, 2019

Conversation

abicky
Copy link
Contributor

@abicky abicky commented Aug 17, 2019

Which issue(s) this PR fixes:
Fixes #2572

What this PR does / why we need it:

This PR improves warning messages using the following configuration:

<match debug.**>
  @type s3
  s3_bucket dummy
  <buffer>
    unused_key 1
  </buffer>
</match>
  • Before 
    2019-08-16 23:17:26 +0900 [warn]: section <buffer> is not used in <match debug.**>
  • After 
    2019-08-18 00:31:03 +0900 [warn]: parameter 'unused_key' in <buffer>
  unused_key 1
</buffer> is not used.

Docs Changes:
no need

Release Note:
same as tile

@abicky
Add a test for fluent#629
b8d06d3 
Signed-off-by: abicky <takeshi.arabiki@gmail.com>
@abicky
Mark sections as used if they are used at least once
9d3a127 
This commit resolves fluent#2572.

Signed-off-by: abicky <takeshi.arabiki@gmail.com>
@repeatedly repeatedly merged commit 22adcee into fluent:master Aug 19, 2019
@repeatedly
Copy link
Member

Looks great. Thanks!

@abicky abicky deleted the resolve-2572 branch August 23, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganmacs ganmacs ganmacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"[warn]: section <buffer> is not used in ..." from s3 plugin
3 participants
@abicky @repeatedly @ganmacs