child_process helper: fix stderr blocking for discard case. fix #2609 #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reopen with IO::NULL is not correct way to discard message. Need to specify IO::NULL when launch process. Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
ganmacs
approved these changes
Oct 15, 2019
| Timeout.timeout(TEST_DEADLOCK_TIMEOUT) do | ||
| ran = false | ||
| # lots of stderr message should not be blocked and message should not be printed in test. | ||
| cmd = "ruby -e 'while !STDIN.eof? && line = STDIN.readline; STDERR.puts line.chomp * 1000; STDOUT.puts line.chomp; STDOUT.flush rescue nil; end'" |
There was a problem hiding this comment.
I'm not sure but it needs to callSTDERR.flush?
There was a problem hiding this comment.
STDERR writes lots of data so no flush call is not critical.
| end | ||
| sleep TEST_WAIT_INTERVAL_FOR_BLOCK_RUNNING until m.locked? || ran | ||
| m.lock | ||
| m.unlock |
There was a problem hiding this comment.
Mutex#unlock should be called in ensure context for safe.
| @@ -281,7 +282,7 @@ def child_process_execute_once( | |||
| stderrio.set_encoding(external_encoding, internal_encoding, encoding_options) | |||
| stderrio_in_use = true | |||
| else | |||
| stderrio.reopen(IO::NULL) if stderrio && stderrio == :discard | |||
There was a problem hiding this comment.
Just checking, This was a bug, right? stderrio cannot be a :discard.
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
repeatedly
added a commit
that referenced
this pull request
Oct 25, 2019
child_process helper: fix stderr blocking for discard case. fix #2609 Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com
Which issue(s) this PR fixes:
Fixes #2609
What this PR does / why we need it:
reopen with IO::NULL is not correct way to discard message.
It replaces ruby side IO object, not process. Thanks nurse-san!
Need to specify IO::NULL when launch the process.
Docs Changes:
No need
Release Note:
Same as title