Fix regex and output warning log correctly #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with https://github.com/fluent/fluentd/blob/7482802d75ba7b61a2997b15a02c45ff6a376e61/lib/fluent/plugin/output.rb#L753 Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
…ists Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
ref: #2523
What this PR does / why we need it:
Fixed regext to match with
fluentd/lib/fluent/plugin/output.rb
Line 753 in 7482802
Be able to output a warning log even if chunk_key is passed.
Docs Changes:
none
Release Note:
same as the title