Update development_dependency to latest version #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
ganmacs
force-pushed
the
update-dev-dependency
branch
10 times, most recently
from
63e228e
to
ff029bc
Compare
https://docs.ruby-lang.org/en/2.7.0/OpenURI.html https://docs.ruby-lang.org/en/2.4.0/OpenURI.html Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
ganmacs
force-pushed
the
update-dev-dependency
branch
from
ff029bc
to
c7a76ce
Compare
ganmacs
commented
Jan 10, 2020
| @@ -281,7 +281,8 @@ def initialize | |||
| @text = "" | |||
| @preamble_source = "" | |||
| @preamble = nil | |||
| URI.open(LICENSE_URL) do |io| | |||
| uri = URI.parse(LICENSE_URL) | |||
There was a problem hiding this comment.
note: this change breaks tests in ruby 2.4 due to NoMethodError(`open' called for URI:Module' ). however I couldn't get the error message since stdout was captured ....
fluentd/test/command/test_plugin_generator.rb
Line 102 in 8610cd7
|
I'm merging this PR since tests for ruby 2.4 are failing now. if you have any questions, feel free to ask! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuta Iwama ganmacs@gmail.com
Which issue(s) this PR fixes:
none
What this PR does / why we need it:
Update development_dependency to latest version
Docs Changes:
none
Release Note:
none