Support @include/include directive for spaces included path. Fix #2485

[cosmo0920]

Based on @repeatedly's patch:
#2485 (comment)

Signed-off-by: Hiroshi Hatake hatake@clear-code.com

Which issue(s) this PR fixes:
Fixes #2485

What this PR does / why we need it:
Support @include/include directive for spaces included path.

Docs Changes:
Needed?
Release Note:
Same as title.

[cosmo0920]

Umm..., tests which are affected this changes are failed...

[cosmo0920]

I used uri.gsub(/ /, '+') instead of URI.encode_www_form_component(uri)/URI.encode(uri).
Because we need to handle spaces in URI.parse(uri).

[ganmacs]

Because we need to handle spaces in URI.parse(uri).

Both methods(URI.encode_www_form_component(uri)/URI.encode(uri)) can replace space with +. Are there any reasons not to use them? I think using them express intentional clearly (it takes me a little time to get why + is used as the replaced char).

irb(main):003:0> URI.encode('/test with ')
=> "/test%20with%20"
irb(main):004:0> URI.encode_www_form_component('/test with ')
=> "%2Ftest+with+"

[cosmo0920]

Both methods(URI.encode_www_form_component(uri)/URI.encode(uri)) can replace space with +. Are there any reasons not to use them? I think using them express intentional clearly (it takes me a little time to get why + is used as the replaced char).

URI.encode_www_form_components will escape drive schema like as C:.

irb>  URI.encode_www_form_component('C:/test with ')
=> "C%3A%2Ftest+with+"

URI.parse does not handle "C%3A%2F" as a schema.

This causes unintentional behavior on this clause:

https://github.com/fluent/fluentd/blob/master/lib/fluent/config/v1_parser.rb#L151

URI.encode has right behavior for this PR but this method is marked as obsoleted:
https://docs.ruby-lang.org/ja/latest/method/URI/s/encode.html
Should we use this method as in the past?

[ganmacs]

URI.parse does not handle "C%3A%2F" as a schema.

URI.encode has right behavior for this PR but this method is marked as obsoleted:
https://docs.ruby-lang.org/ja/latest/method/URI/s/encode.html

I see...

OK, then 👍

[cosmo0920]

@repeatedly ?

[cosmo0920]

I'll merge this PR after finishing CI.