Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Fix IPv6 dual stack mode issue for udp socket. fix #2768 #2781

Merged
merged 2 commits into from
Jan 20, 2020

Conversation

repeatedly
Copy link
Member

Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com

Which issue(s) this PR fixes:
Fixes #2768

What this PR does / why we need it:
Set IPV6_V6ONLY to udp socket.

Docs Changes:
No need

Release Note:
Same at title.

Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@ganmacs
Copy link
Member

ganmacs commented Jan 20, 2020

Can you please describe more detail? It's hard to understand why this code fixes the problem.

Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly
Copy link
Member Author

Add comment.

Copy link
Member

@ganmacs ganmacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. the reason is the same as the TCP's one

@repeatedly repeatedly merged commit 2fc79e5 into master Jan 20, 2020
@repeatedly repeatedly deleted the fix-dual-stack-ipv6-udp-issue branch January 20, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UDP socket should also disable dual stack mode.
2 participants