Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Use binmode for Tempfile #2869

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Conversation

ganmacs
Copy link
Member

@ganmacs ganmacs commented Mar 10, 2020

Which issue(s) this PR fixes:
fixes https://ci.appveyor.com/project/fluent/fluentd/builds/31358039/job/72o6ik1u4apf6bsu

What this PR does / why we need it:

I've noticed I had added the wrong test in windows in #2858

Docs Changes:

no need

Release Note:

no need

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
@ganmacs ganmacs requested a review from cosmo0920 March 10, 2020 02:31
@ganmacs ganmacs self-assigned this Mar 10, 2020
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I'm also just fixing with the exact same patch. 💪
Thank you!!

@ganmacs
Copy link
Member Author

ganmacs commented Mar 10, 2020

Sorry for bothering you 🙇 . Thanks!

@ganmacs ganmacs merged commit 26f6e71 into fluent:master Mar 10, 2020
@ganmacs ganmacs deleted the test-fix-for-windows branch March 10, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants