Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: test/test_supervisor.rb #4044

Merged
merged 3 commits into from
Feb 8, 2023
Merged

refactor: test/test_supervisor.rb #4044

merged 3 commits into from
Feb 8, 2023

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Feb 7, 2023

Which issue(s) this PR fixes:

What this PR does / why we need it:

  • test: use double quotes for strings containing line breaks
  • test: use .& for nil check
  • test: remove begin rescue end when Process.kill

Docs Changes:

Release Note:

@abetomo
test: use double quotes for strings containing line breaks
11f9358 
Signed-off-by: abetomo <abe@enzou.tokyo>
@abetomo
test: use .& for nil check
84ceac9 
Signed-off-by: abetomo <abe@enzou.tokyo>
@abetomo
test: remove begin rescue end when Process.kill
c6a76ce 
It is more helpful to the investigation if the exception is not ignored.

Signed-off-by: abetomo <abe@enzou.tokyo>
kou
kou approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ashie ashie merged commit aeac168 into fluent:master Feb 8, 2023
@ashie
Copy link
Member

ashie commented Feb 8, 2023

Thanks!

@abetomo abetomo deleted the refactor_test_supervisor branch February 8, 2023 00:13
@ashie ashie added this to the v1.16.0 milestone Feb 9, 2023
@daipom daipom mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

@ashie ashie ashie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@abetomo @ashie @kou