Add Engine#msgpack_factory for v0.14 compatibility #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeatedly
force-pushed
the
add-msgpack-factory-api
branch
from
e8b868b
to
aac0b72
Compare
|
@frsyuki @tagomoris @sonots Could you check this PR? If no problem, I will merge it and release fluentd v0.12.17. |
| end | ||
|
|
||
| def unpacker(io = nil) | ||
| MessagePack::Unpacker.new(io) |
There was a problem hiding this comment.
I think this (and packer) method should be:
def unpacker(*args)
MessagePack::Unpacker.new(*args)
end
because Unpacker accepts some options such as allow_unknown_ext: true in addition to io.
There was a problem hiding this comment.
Ah, I see. I will update the patch. Thanks
|
I commented one thing. Other than that, looks good to me. Good job. |
|
Applied. Does someone have any concern? |
|
if there are no any concerns, I will merge this today. |
repeatedly
added a commit
that referenced
this pull request
Nov 2, 2015
Add Engine#msgpack_factory for v0.14 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v0.14, core and plugin use
Engine#msgpack_factoryfor creating MessagePack Packer / Unpacker.For supporting v0.12 and v0.14 in plugin code, providing same API is better.
Related to #653