Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies between files #799

Merged
merged 2 commits into from
Feb 10, 2016
Merged

Fix dependencies between files #799

merged 2 commits into from
Feb 10, 2016

Commits on Feb 9, 2016

  1. fix indentations, styles and typo for "Exception"

    @tagomoris
    tagomoris committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    2b11a82 View commit details
    Browse the repository at this point in the history

  2. Fix to do require for required files straightforward, per files 

    * Currently, all required files are loaded by `lib/fluent/load.rb` even for tests
  * This file creates the implicit order of files to be loaded
  * There's no explicit dependency definition, and there are many circular dependencies
  * This situation is totally broken
* Without this change, we can't run tests by `bundle exec rake test TEST=test/file.rb`
  * Running whole tests consumes long time, and it's not acceptable

This change is to make straightforward dependency from all files to others.
We can load any file in fluentd source code, make clean dependencies, and
also can run each files itself to test it.
    @tagomoris
    tagomoris committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    7d4baa0 View commit details
    Browse the repository at this point in the history