Suppress a lot of warnings #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some warnings may conflict with other PRs, so I leave these warnings. |
| else | ||
| convert_type(name, value) | ||
| end | ||
| record[name] = convert_type(name, value) |
There was a problem hiding this comment.
Calling convert_type heavily is high cost.
So we should not call convert_type when user doesn't specify types parameter.
|
I have fixed and pushed. |
|
LGTM. (Squash required after all reviewer comments.) |
|
Is it possible to integrate ruby warning check into CI? Otherwise, I think same things happen again in the future. |
|
Good job anyway, this allows plugin developers to use ruby -w for their own plugins. Before, fluentd itself showed lots of warnings, so ruby -w for plugins did not work effectively. |
|
@sonots what is "ruby warning check" you mentioned? |
|
Checking whether ruby -w tells warnings or not |
|
It's impossible to remove all warnings immediately (because there are some/many warnings from libraries which fluentd depends on). |
* Do not shadow local variables test/plugin/test_in_dummy.rb:91: warning: assigned but unused variable - time lib/fluent/plugin/in_dummy.rb:45: warning: shadowing outer local variable - e test/test_event.rb:94: warning: shadowing outer local variable - time test/test_event.rb:142: warning: shadowing outer local variable - time test/plugin/test_in_stream.rb:20: warning: shadowing outer local variable - time test/plugin/test_in_stream.rb:35: warning: shadowing outer local variable - time test/plugin/test_in_stream.rb:51: warning: shadowing outer local variable - time test/plugin/test_in_stream.rb:68: warning: shadowing outer local variable - time test/plugin/test_in_stream.rb:84: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:43: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:59: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:75: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:113: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:150: warning: shadowing outer local variable - tag test/plugin/test_in_http.rb:163: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:184: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:200: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:238: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:262: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:280: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:43: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:59: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:75: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:113: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:150: warning: shadowing outer local variable - tag test/plugin/test_in_http.rb:163: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:184: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:200: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:238: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:262: warning: shadowing outer local variable - time test/plugin/test_in_http.rb:280: warning: shadowing outer local variable - time * Initialize uninitialized instance variables lib/fluent/test/base.rb:31: warning: instance variable @now not initialized lib/fluent/test/input_test.rb:121: warning: instance variable @run_post_conditions not initialized lib/fluent/log.rb:324: warning: instance variable @suppress_repeated_stacktrace not initialized lib/fluent/config/configure_proxy.rb:183: warning: instance variable @current_description not initialized lib/fluent/plugin/buf_file.rb:147: warning: instance variable @symlink_path not initialized lib/fluent/output.rb:212: warning: instance variable @secondary not initialized lib/fluent/output.rb:220: warning: instance variable @secondary not initialized lib/fluent/mixin.rb:201: warning: instance variable @localtime not initialized lib/fluent/mixin.rb:201: warning: instance variable @Timezone not initialized lib/fluent/mixin.rb:149: warning: instance variable @remove_tag_prefix not initialized lib/fluent/mixin.rb:150: warning: instance variable @remove_tag_suffix not initialized test/config/test_system_config.rb:81: warning: instance variable @emit_error_log_interval not initialized lib/fluent/plugin/in_syslog.rb:111: warning: instance variable @use_default not initialized lib/fluent/root_agent.rb:89: warning: instance variable @without_source not initialized lib/fluent/process.rb:488: warning: instance variable @detach_process not initialized * Define assert_equal_event_time once lib/fluent/test/base.rb:35: warning: method redefined; discarding old assert_equal_event_time lib/fluent/test/base.rb:35: warning: previous definition of assert_equal_event_time was here * Add '_' prefix to unused variables test/test_parser.rb:1046: warning: assigned but unused variable - time lib/fluent/test/output_test.rb:91: warning: assigned but unused variable - record lib/fluent/config/element.rb:138: warning: assigned but unused variable - block * Remove unused variables test/test_parser.rb:453: warning: assigned but unused variable - format test/test_mixin.rb:211: warning: assigned but unused variable - d test/test_formatter.rb:55: warning: assigned but unused variable - formatter test/test_buffer.rb:581: warning: assigned but unused variable - e test/config/test_dsl.rb:164: warning: assigned but unused variable - root lib/fluent/parser.rb:619: warning: assigned but unused variable - e lib/fluent/plugin/in_exec.rb:56: warning: assigned but unused variable - localtime lib/fluent/plugin/in_exec.rb:58: warning: assigned but unused variable - utc lib/fluent/event_router.rb:105: warning: assigned but unused variable - c * Rename block parameter lib/fluent/config/v1_parser.rb:159: warning: shadowing outer local variable - path lib/fluent/config/parser.rb:84: warning: shadowing outer local variable - path lib/fluent/plugin/buf_file.rb:175: warning: assigned but unused variable - chunk lib/fluent/plugin/buf_file.rb:177: warning: assigned but unused variable - timestamp lib/fluent/plugin/buf_file.rb:181: warning: assigned but unused variable - chunk lib/fluent/plugin/buf_file.rb:183: warning: assigned but unused variable - timestamp * Use defined global variable lib/fluent/plugin.rb:129: warning: global variable `$log' not initialized * Remove redundant condition lib/fluent/log.rb:255: warning: instance variable @suppress_repeated_stacktrace not initialized lib/fluent/log.rb:261: warning: instance variable @suppress_repeated_stacktrace not initialized * Define instance method once lib/fluent/plugin/in_tail.rb:457: warning: method redefined; discarding old swap_state lib/fluent/plugin/in_tail.rb:457: warning: previous definition of swap_state was here
okkez
force-pushed
the
suppress-ruby-warnings
branch
from
07cac37
to
76c3ac2
Compare
|
@tagomoris squashed! |
|
@okkez Thanks! I'll merge this after Travis green (AppVeyor looks in trouble now). |
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to wipe out warnings.