Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate msgpack_factory from Engine to a file #871

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Separate msgpack_factory from Engine to a file #871

merged 1 commit into from
Mar 31, 2016

Conversation

tagomoris
Copy link
Member

  • to make it available from many classes without loading whole Engine
  • Many classes/plugins requires accessibility for msgpack_factory to handle Fluent::EventTime
    • but Engine is too big to load every time (especially in tests)
  • This patch make it possible to use msgpack_factory from anywhere using Mixin
    • and fetched msgpack_factory is the same instance for Engine after Engine.init
    • to make it possible to use other ext types registered via Engine
  • There're another methods to create factory instances without Engine effects
    • it should be required especially for tests

@tagomoris
Separate msgpack_factory from Engine to a file
fb09f3b 
* to make it available from many classes without loading whole Engine
* Many classes/plugins requires accessibility for msgpack_factory to handle Fluent::EventTime
  * but Engine is too big to load every time (especially in tests)
* This patch make it possible to use msgpack_factory from anywhere using Mixin
  * and fetched msgpack_factory is the same instance for Engine after Engine.init
  * to make it possible to use other ext types registered via Engine
* There're another methods to create factory instances without Engine effects
  * it should be required especially for tests
@tagomoris
Copy link
Member Author

@repeatedly @sonots any comments? I'll merge this few hours later if not.

@sonots
Copy link
Member

sonots commented Mar 31, 2016

👍

@tagomoris tagomoris merged commit 052d791 into master Mar 31, 2016
@tagomoris
Copy link
Member Author

Merged.

@tagomoris tagomoris deleted the separate-msgpack-factory-from-engine branch May 17, 2016 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tagomoris @sonots