Add simplified syntax for hash and array #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* to specify values with very simple comma (and colon for key-value separator) * to re-format values because comma-separated values doesn't have type information It looks to satisfy various use-cases of 3rd party plugins, and this change is just additional change to allow format which is currently denied as ConfigError.
|
This change is exclusive with #874 |
|
I prefer this than #874 |
| @@ -124,10 +124,33 @@ class TestConfigTypes < ::Test::Unit::TestCase | |||
|
|
|||
| test 'hash' do | |||
| assert_equal({"x"=>"v","k"=>1}, Config::HASH_TYPE.call('{"x":"v","k":1}', {})) | |||
| assert_equal({"x"=>"v","k"=>"1"}, Config::HASH_TYPE.call('x:v,k:1', {})) | |||
There was a problem hiding this comment.
Could you add a test a hash with , surrounded by spaces?
| @@ -80,19 +80,58 @@ def self.bool_value(str) | |||
| SIZE_TYPE = Proc.new { |val, opts| Config.size_value(val) } | |||
| BOOL_TYPE = Proc.new { |val, opts| Config.bool_value(val) } | |||
| TIME_TYPE = Proc.new { |val, opts| Config.time_value(val) } | |||
|
|
|||
| REFORMAT_VALUES = ->(type, value) { | |||
There was a problem hiding this comment.
Why REFORMAT_VALUES? REFORMAT_VALUE?
There was a problem hiding this comment.
Fixed to REFORMAT_VALUE
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks to satisfy various use-cases of 3rd party plugins, and this change is just additional
change to allow format which is currently denied as ConfigError.