Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide chunk.key for v0.12 plugins which specifies key in overriding #emit #992

Merged
merged 2 commits into from
May 27, 2016

Conversation

tagomoris
Copy link
Member

3rd party BufferedOutput plugins sometimes overrides #emit to control chunking keys.
This change is to provide compatibility for such plugins by using metadata.variables to pass specified chunking key to #write.

This fix solves #990.

@tagomoris
Copy link
Member Author

I checked this change with fluent-plugin-sql and configuration below:

<source>
  type dummy
  tag test
</source>

<match test>
  @type sql
  host localhost
  port 5432
  database fluentd_test
  adapter postgresql
  username fluentd
  password fluentd
  <table>
    table mytest
    column_mapping message:message
  </table>
  <table test>
    table mytest
    column_mapping message:message
  </table>
</match>

@tagomoris tagomoris changed the title Fix compat buffered output overrides emit Provide chunk.key for v0.12 plugins which specifies key in overriding #emit May 26, 2016
@tagomoris tagomoris merged commit c291f75 into master May 27, 2016
@tagomoris tagomoris deleted the fix-compat-buffered-output-overrides-emit branch June 2, 2016 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant