fix analyzer.

flutter-webrtc · May 8, 2024 · 3f2be15 · 3f2be15
1 parent b2fab26
commit 3f2be15
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 11 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -29,7 +29,6 @@ linter:
     - valid_regexps
     - void_checks
     # - always_put_required_named_parameters_first # we prefer having parameters in the same order as fields https://github.com/flutter/flutter/issues/10219
-    - always_require_non_null_named_parameters
     - always_specify_types
     - annotate_overrides
     - prefer_single_quotes
@@ -63,4 +62,5 @@ analyzer:
 
   exclude:
     - lib/src/grammar_parser.dart
-    - tool/*
+    - tool/*
+    - test/*
diff --git a/example/pubspec.yaml b/example/pubspec.yaml
@@ -25,6 +25,7 @@ dependencies:
     path: ../
   shared_preferences: ^2.2.0
   permission_handler: ^11.1.0
+  flutter_webrtc: ^0.10.4
 
 dev_dependencies:
   flutter_test:

diff --git a/lib/sip_ua.dart b/lib/sip_ua.dart
@@ -1,4 +1,3 @@
-/// only expose the bare minimum of internals required
 export 'src/enum_helper.dart';
 export 'src/sip_ua_helper.dart';
 export 'src/transport_type.dart';
diff --git a/lib/src/config.dart b/lib/src/config.dart
@@ -238,8 +238,8 @@ class Checks {
         dst!.registrar_server = parsed;
       }
     },
-    'register_extra_headers': (src, dst) {
-      var register_extra_headers = src?.register_extra_headers;
+    'register_extra_headers': (Settings src, Settings? dst) {
+      List<String>? register_extra_headers = src.register_extra_headers;
       if (register_extra_headers == null) return;
       dst?.register_extra_headers = register_extra_headers;
     },

diff --git a/lib/src/logger.dart b/lib/src/logger.dart
@@ -28,7 +28,7 @@ class MyLogPrinter extends LogPrinter {
   MyLogPrinter(this.currentWorkingDirectory);
 
   static final Map<Level, AnsiColor> levelColors = <Level, AnsiColor>{
-    Level.verbose: AnsiColor.fg(AnsiColor.grey(0.5)),
+    Level.trace: AnsiColor.fg(AnsiColor.grey(0.5)),
     Level.debug: AnsiColor.none(),
     Level.info: AnsiColor.fg(12),
     Level.warning: AnsiColor.fg(208),

diff --git a/lib/src/sip_ua_helper.dart b/lib/src/sip_ua_helper.dart
@@ -686,7 +686,7 @@ class RegisterParams {
   /// Allow extra headers and Contact Params to be sent on REGISTER
   /// Mainly used for RFC8599 Support
   /// https://github.com/cloudwebrtc/dart-sip-ua/issues/89
-  List<String> extraHeaders = [];
+  List<String> extraHeaders = <String>[];
   Map<String, dynamic> extraContactUriParams = <String, dynamic>{};
 }
 

diff --git a/lib/src/transports/tcp_socket.dart b/lib/src/transports/tcp_socket.dart
@@ -169,11 +169,11 @@ class SIPUATcpSocket extends SIPUASocketInterface {
 
   @override
   bool isConnecting() {
-    // TODO: implement isConnecting
+    // TODO(cloudwebrtc): implement isConnecting
     throw UnimplementedError();
   }
 
   @override
-  // TODO: implement url
+  // TODO(cloudwebrtc): implement url
   String? get url => throw UnimplementedError();
 }
diff --git a/lib/src/ua.dart b/lib/src/ua.dart
@@ -660,7 +660,8 @@ class UA extends EventManager {
         return;
       }
     } else if (method == SipMethod.SUBSCRIBE) {
-      if (listeners['newSubscribe']?.length == 0) {
+      // ignore: collection_methods_unrelated_type
+      if (listeners['newSubscribe'] == null) {
         request.reply(405);
 
         return;

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -21,6 +21,6 @@ dependencies:
 
 
 dev_dependencies:
-  lints: ^3.0.0
   import_sorter: ^4.6.0
+  lints: ^3.0.0
   test: any