Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality #326

Merged
merged 22 commits into from
Nov 7, 2022
Merged

Code quality #326

merged 22 commits into from
Nov 7, 2022

Conversation

Perondas
Copy link
Collaborator

@Perondas Perondas commented Nov 3, 2022 •
edited
Loading

Closes: #323

Perondas and others added 20 commits October 24, 2022 15:23
Implemented lints
94cc76a 
Working on Various issues with code quality  flutter-webrtc#323
Fixed up example
62fd418
Further lint fixes
dce020f 
Working on flutter-webrtc#323
Began nullability rework
2c90c1b 
Working on flutter-webrtc#323
Made sockets strongly typed
f77c293
Cleaned up utils
7088cec 
Working 0n flutter-webrtc#323
Continued nullability rework + updated constant
35b3687 
Working on Various issues with code quality  flutter-webrtc#323
Fixed late issue in dialog
f82a32e
Fixed request sender
5c3e7ad
Fixed bug in authentication
c0af9c3
Slimmed down constructor of RTCSession
56a9a21 
Working on Various issues with code quality  flutter-webrtc#323
Fixed a test
55ce8a4
Reworked constructor of UA
0d7bddb 
Working on Various issues with code quality  flutter-webrtc#323
Reworked transport class
4373b90 
Fixed a potential infite loop
Made field final
Working on Various issues with code quality  flutter-webrtc#323
Reworked options
a61bdb8
Reworked messsage class
d28d268 
Workingon Various issues with code quality  flutter-webrtc#323
Cleaned up math class
2ae24cc 
Working on Various issues with code quality  flutter-webrtc#323
Reworked subscriber class
32113c7 
Working in Various issues with code quality  flutter-webrtc#323
Removed unwanted late
b3ef9fd
Fixed a possible concurrent modification exception
5a84661 
Working on Various issues with code quality  flutter-webrtc#323
cloudwebrtc
cloudwebrtc approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Perondas Perondas merged commit c4a41de into flutter-webrtc:master Nov 7, 2022
@Perondas Perondas mentioned this pull request Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Various issues with code quality
2 participants
@Perondas @cloudwebrtc