This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
[WIP] Adapt e2e scripts so they can be used more generally (and locally) #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
reviewed
Apr 11, 2019
test/e2e/e2e-golang.sh
Outdated
| curl -O https://storage.googleapis.com/golang/go${GO_VERSION}.linux-amd64.tar.gz | ||
| echo ">>> Installing go ${GO_VERSION} to $GOBASE/go" | ||
| if ! [ -f "go${GO_VERSION}.linux-amd64.tar.gz" ]; then | ||
| curl -O https://storage.googleapis.com/golang/go${GO_VERSION}.linux-amd64.tar.gz |
There was a problem hiding this comment.
This won't work for other architectures (e.g. darwin)
I think that we should simply run e2e tests as a continuation from building through the Makefile.
As an optimization, e2e CircleCI task could gather the artifacts from the build stage https://circleci.com/docs/2.0/workflows/#using-workspaces-to-share-data-among-jobs
squaremo
force-pushed
the
build/e2e-testing
branch
from
9ed48c1
to
d601c6d
Compare
- make them all respect a base directory, to avoid stomping on /usr/local - add some notes in each about what they depend on
Since Go 1.9, and after fierce resistance, wildcard paths do not include `vendor`. Hence we can simplify the `go test` command, so that 1. it's easier to grok; 2. the output is less verbose.
squaremo
force-pushed
the
build/e2e-testing
branch
from
d601c6d
to
a387d5a
Compare
Merged
|
Superseded by #2058 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far:
/usr/local