Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add Flux deployment kustomization #2375

Merged
merged 5 commits into from
Aug 20, 2019
Merged

Add Flux deployment kustomization #2375

merged 5 commits into from
Aug 20, 2019

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Aug 20, 2019

Add docs with Kustomize install instructions

Update docs with Kustomize install instructions
@stefanprodan stefanprodan added the docs Issue or PR relates to documentation label Aug 20, 2019
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this no longer makes the get started tutorial accessible to completely newcomers, instead I would make this either an extended part of this tutorial as a section or a follow up tutorial in a new document.

@stefanprodan
Copy link
Member Author

I think the opposite. Instead of pulling the whole Flux repo and editing files, now you can just copy/past/run the instructions, way easier and clean in my opinion.

@hiddeco
Copy link
Member

hiddeco commented Aug 20, 2019

@stefanprodan agreed, but you no longer understand what happens, just that it works.

Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comments for the minute ..

docs/tutorials/get-started.md Outdated Show resolved Hide resolved
docs/tutorials/get-started.md Outdated Show resolved Hide resolved
docs/tutorials/get-started.md Outdated Show resolved Hide resolved
docs/tutorials/get-started.md Outdated Show resolved Hide resolved
@squaremo
Copy link
Member

With respect to whether this is a good way to show people how to install flux for the first time:

  • I agree with Hidde that a tutorial should aim to instruct
  • I don't think using using Kustomize gets in the way of instructing, especially (or that getting people to edit files was superior on that count, necessarily). But it might need a bit of explanation of why things are being done.
  • If using Kustomize is to be preferred -- we're effectively recommending it, here -- we might need to revisit some other bits of doc as well.

@stefanprodan
Copy link
Member Author

@squaremo @hiddeco I've moved the Kustomize install docs to a dedicated section and I've added the two example repos as next steps.

```

The default sync frequency is 5 minutes. This can be tweaked easily.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this was already there or is new, but my thought while reading this was "can be tweaked easily how?"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already there. Let's address it in #2298

docs/tutorials/index.rst Show resolved Hide resolved
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Stefan 🔥

@stefanprodan stefanprodan merged commit 79f13f8 into master Aug 20, 2019
@stefanprodan stefanprodan deleted the kustomization branch August 20, 2019 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Issue or PR relates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants