Prevent missing ascender from breaking layout #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@devongovett , as you can probably guess from all these PRs I'm finally getting around to upgrading off my fork. Great to see lots of progress in pdfkit since then, thanks for all your work.) |
devongovett
added a commit
that referenced
this pull request
Sep 12, 2014
Prevent missing ascender from breaking layout
|
@ef4 thanks for all the PRs, really helpful. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZapfDingbats (and perhaps others) has no ascender or descender attributes. pdfkit is treating them as
NaN, which causesdocument.yto also ends up asNaNif you try to render any text in this font.