Skip to content

Commit

Permalink
fix(chore): forward debug settings to transition on internal use
Browse files Browse the repository at this point in the history 
Some modules use the transition module internall to do animations. But some missed to provide all debug settings from the parent module.
Especially the silent setting was not forwarded.
So whenever someone tried this

$(el).dropdown({
  silent: true
});
This was ignored by the transition module (in case it logs errors), because the default setting of silent is false in all modules.
  • Loading branch information
@lubber-de
lubber-de committed Aug 24, 2022
1 parent e32d5af commit baa8544
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/definitions/modules/accordion.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ $.fn.accordion = function(parameters) {
useFailSafe : true,
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
duration : settings.duration,
skipInlineHidden : true,
onComplete: function() {
Expand Down Expand Up @@ -255,6 +256,7 @@ $.fn.accordion = function(parameters) {
useFailSafe : true,
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
duration : settings.duration,
skipInlineHidden : true
})
Expand Down Expand Up @@ -325,6 +327,7 @@ $.fn.accordion = function(parameters) {
useFailSafe : true,
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
duration : settings.duration,
skipInlineHidden : true
})
Expand Down
6 changes: 6 additions & 0 deletions src/definitions/modules/dimmer.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,9 @@ $.fn.dimmer = function(parameters) {
}
$dimmer
.transition({
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
displayType : settings.useFlex
? 'flex'
: 'block',
Expand Down Expand Up @@ -307,6 +310,9 @@ $.fn.dimmer = function(parameters) {
module.verbose('Hiding dimmer with css');
$dimmer
.transition({
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
displayType : settings.useFlex
? 'flex'
: 'block',
Expand Down
3 changes: 3 additions & 0 deletions src/definitions/modules/dropdown.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2891,6 +2891,7 @@ $.fn.dropdown = function(parameters) {
animation : settings.label.transition,
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
duration : settings.label.duration
})
;
Expand Down Expand Up @@ -3679,6 +3680,7 @@ $.fn.dropdown = function(parameters) {
animation : transition + ' in',
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
duration : settings.transition.showDuration || settings.duration,
queue : true,
onStart : start,
Expand Down Expand Up @@ -3726,6 +3728,7 @@ $.fn.dropdown = function(parameters) {
duration : settings.transition.hideDuration || settings.duration,
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
queue : false,
onStart : start,
displayType: module.get.displayType(),
Expand Down
4 changes: 4 additions & 0 deletions src/definitions/modules/modal.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,8 @@ $.fn.modal = function(parameters) {
$module
.transition({
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
animation : (settings.transition.showMethod || settings.transition) + ' in',
queue : settings.queue,
duration : settings.transition.showDuration || settings.duration,
Expand Down Expand Up @@ -602,6 +604,8 @@ $.fn.modal = function(parameters) {
$module
.transition({
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
animation : (settings.transition.hideMethod || settings.transition) + ' out',
queue : settings.queue,
duration : settings.transition.hideDuration || settings.duration,
Expand Down
2 changes: 2 additions & 0 deletions src/definitions/modules/popup.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,7 @@ $.fn.popup = function(parameters) {
queue : false,
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
duration : settings.transition.showDuration || settings.duration,
onComplete : function() {
module.bind.close();
Expand All @@ -462,6 +463,7 @@ $.fn.popup = function(parameters) {
duration : settings.transition.hideDuration || settings.duration,
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
onComplete : function() {
module.reset();
callback.call($popup, element);
Expand Down
2 changes: 2 additions & 0 deletions src/definitions/modules/search.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -998,6 +998,7 @@ $.fn.search = function(parameters) {
animation : settings.transition + ' in',
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
duration : settings.duration,
onShow : function() {
var $firstResult = $module.find(selector.result).eq(0);
Expand Down Expand Up @@ -1033,6 +1034,7 @@ $.fn.search = function(parameters) {
animation : settings.transition + ' out',
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
duration : settings.duration,
onComplete : function() {
callback();
Expand Down
2 changes: 2 additions & 0 deletions src/definitions/modules/toast.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ $.fn.toast = function(parameters) {
queue : false,
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
duration : settings.transition.showDuration,
onComplete : function() {
callback.call($toastBox, element);
Expand All @@ -410,6 +411,7 @@ $.fn.toast = function(parameters) {
duration : settings.transition.hideDuration,
debug : settings.debug,
verbose : settings.verbose,
silent : settings.silent,
interval : 50,

onBeforeHide: function(callback){
Expand Down

0 comments on commit baa8544

Please sign in to comment.