Skip to content

Commit

Permalink
fix(emoji,flag): default lineheight should meet text
Browse files Browse the repository at this point in the history
Emojis and flags were larger than the inheriting line-height, resulting in larger dropdowns when they contain such emojis/flags
This PR makes them in line with surrounding text.

I tag this as breaking change, because existing projects using emojis will get slightly smaller emojis unless they provide a size class.
  • Loading branch information
lubber-de committed Apr 26, 2022
1 parent 53c6abb commit f005005
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/themes/default/elements/emoji.variables
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@
/* Emoji Variables */
@opacity: 1;
@loadingDuration: 2s;
@emojiLineHeight: @headerLineHeight;
@emojiLineHeight: 1em;
2 changes: 1 addition & 1 deletion src/themes/default/elements/flag.variables
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
Element
--------------------*/

@flagLineHeight: @headerLineHeight;
@flagLineHeight: 1em;

0 comments on commit f005005

Please sign in to comment.