fix(form): file upload fields trigger error using jquery > 3.4.0 #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
|
That was fast, thanks. |
lubber-de
changed the title
lubber-de
removed
the
state/awaiting-reviews
This was referenced Feb 22, 2023
lubber-de
added a commit
that referenced
this pull request
Feb 26, 2023
This PR reverts #1950 as the cause of the original issue was related to the separate dirty events which were refactored before 2.8.8 was released. I also added some checks for reset and set values as file inputs would otherwise return a js error as file input cannot be set any value other than an empty string. Additionally this PR simplifies the input change event detection as we dont support older browsers than ie11 and avoid memory leaks when attachEvents behavior is used and the form gets detroyed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a form contains a file upload field it is also bound to several form events which are not supposed to happen on those and do not work because flie upload fields are limited in access.
That said, when using jQuery > 3.4.0, it triggers a
Maximum callstack exceeded insteadTestcase
Broken
"maximum callstack exceeded"
https://jsfiddle.net/vzctb5pu/2/
Fixed
Nothing 🙂
https://jsfiddle.net/lubber/7f269p84/8/
Screenshot