-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump JSON Schema test suite #109
Changes from all commits
5e489fd
11e6e72
2415319
65b81d1
4476514
5f3ad79
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,12 +44,20 @@ all() -> | |
|
||
init_per_suite(Config) -> | ||
{ok, _} = application:ensure_all_started(jesse), | ||
SkipList = | ||
[ | ||
{<<"ref">>, <<"Location-independent identifier">>} | ||
, {<<"ref">>, <<"Recursive references between schemas">>} | ||
, {<<"ref">>, <<"Location-independent identifier with base URI" | ||
" change in subschema">>} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so, 3 test-cases are skipped. Seems all 3 require "arbitrary document-local reference URI lookups" / "location indpendent identifiers", but it seems it would be very difficult to implement them efficiently. Naive way would be to just do recursive descent from |
||
], | ||
get_tests( "standard" | ||
, <<"http://json-schema.org/draft-04/schema#">> | ||
, Config) | ||
++ get_tests( "extra" | ||
, <<"http://json-schema.org/draft-04/schema#">> | ||
, Config) | ||
++ [{skip_list, SkipList}] | ||
++ Config. | ||
|
||
end_per_suite(_Config) -> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it crashes when the schema is a
map
. We caught this today before shipping some code to production... is there a reason not to support map format schemas here? It seems to work elsewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this was not intentional. I'll make a fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nalundgaard, may you please check that fix from #113 works for you?