Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude earlier errors when checking oneOf/anyOf with allowed_errors.… #81

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Exclude earlier errors when checking oneOf/anyOf with allowed_errors.… #81

merged 1 commit into from
Aug 14, 2019

Conversation

seriyps
Copy link
Contributor

@seriyps seriyps commented Jul 5, 2019

Fixes #80.

@seriyps
Copy link
Contributor Author

seriyps commented Jul 5, 2019

Travis failed because of some travis issue (not able to download OTP to build agant). Probably should be restarted.

@seriyps
Copy link
Contributor Author

seriyps commented Jul 8, 2019

Oh, seems to just trigger rebuild wouldn't help, because they don't have all mentioned erlang packages for ubuntu 16.04, see https://storage.googleapis.com/travis-ci-language-archives/

@seriyps
Copy link
Contributor Author

seriyps commented Jul 16, 2019

This travis issue was discussed on travis forum: https://travis-ci.community/t/erlang-18-3-couldnt-be-pulled/3836
Seems we should configure "matrix" to run OTP 18 on Ubuntu trusty (example: https://travis-ci.org/amatalai/beam_inspect/builds/548605346/config)

And maybe reduce amount of minor releases of OTP 19 to just OTP 19.3

@seriyps seriyps mentioned this pull request Jul 16, 2019
Merged
@seriyps seriyps force-pushed the oneof-anyof-allowed_errors-prev_error branch from fcad1d2 to f476bff Compare July 25, 2019 11:39
@seriyps
Copy link
Contributor Author

seriyps commented Jul 25, 2019

Build is fixed now (failed continuous-integration/travis-ci/push is irrelevant). I guess I'll merge this one next week as well, if nobody will speak against?

@seriyps seriyps merged commit 512f206 into for-GET:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreineculau andreineculau Awaiting requested review from andreineculau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

anyOf / OneOf returns unexpected error with allowed_errors=infinity
1 participant
@seriyps