Compatibility with text 2 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psibi
reviewed
Feb 21, 2024
|
Pushed a release to Hackage, thanks! |
chrisdone
reviewed
Mar 5, 2024
| type I16 = Int | ||
| #endif | ||
|
|
||
| -- FIXME fail with Randomized with seed 1862667972 |
There was a problem hiding this comment.
What happened to this FIXME?
There was a problem hiding this comment.
test/Main.hs:347:15:
1) Database.ODBC.SQLServer, Conversion to SQL, QuickCheck roundtrip: HS=Datetime2, SQL=datetime2
uncaught exception: ODBCException
UnsuccessfulReturnCode "odbc_SQLExecDirectW" (-1) "[Microsoft][ODBC Driver 18 for SQL Server][SQL Server]Conversion failed when converting date and/or time from character string." (Just "22007")
(after 15 tests)
Datetime2 {unDatetime2 = 1796-07-15 23:59:60.9660284}
I guess SQL Server doesn't like the leap second on a day that shouldn't have leap seconds?
EDIT: Actually, SQL Server doesn't support leap seconds at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code thanks to @jberryman
We've been using this code in production at my employer since June 2023 without issue.