Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get RM costs from consumption entry in manufacture SE #39822

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Feb 8, 2024

Work Order

image

Material Transfer Entry

image

Material Consumption Entry

image

Before [FG Rate gets fetched from BOM]

image

After [FG Rate gets set based on Material Transfer]

image

image

Validations

  • RM's can't be added directly in the Manufacture entry. All the material consumption needs to be done using Material Consumption for Manufacture entries.
  • Partial Manufacture entries are not allowed. As FG's rate can't distributed equally in that case.

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 8, 2024
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Feb 8, 2024
@s-aga-r s-aga-r force-pushed the FIX-9480-1 branch 2 times, most recently from 7b8fa74 to 3f35b67 Compare February 9, 2024 09:53
@s-aga-r s-aga-r marked this pull request as ready for review February 11, 2024 11:32
@rohitwaghchaure rohitwaghchaure merged commit 39067c7 into frappe:develop Feb 11, 2024
13 checks passed
mergify bot pushed a commit that referenced this pull request Feb 11, 2024
s-aga-r added a commit that referenced this pull request Feb 11, 2024
…39822) (#39847)

feat: get RM costs from consumption entry in manufacture SE (#39822)

(cherry picked from commit 39067c7)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
mergify bot added a commit that referenced this pull request Feb 11, 2024
…39822) (#39847)

feat: get RM costs from consumption entry in manufacture SE (#39822)

(cherry picked from commit 39067c7)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
(cherry picked from commit 2d5f186)
s-aga-r pushed a commit that referenced this pull request Feb 11, 2024
…39822) (backport #39847) (#39849)

feat: get RM costs from consumption entry in manufacture SE (backport #39822) (#39847)

feat: get RM costs from consumption entry in manufacture SE (#39822)

(cherry picked from commit 39067c7)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
(cherry picked from commit 2d5f186)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Feb 11, 2024
# [15.13.0](v15.12.2...v15.13.0) (2024-02-11)

### Features

* get RM costs from consumption entry in manufacture SE (backport [#39822](#39822)) (backport [#39847](#39847)) ([#39849](#39849)) ([beb4137](beb4137))
frappe-pr-bot pushed a commit that referenced this pull request Feb 14, 2024
# [15.14.0](v15.13.0...v15.14.0) (2024-02-14)

### Bug Fixes

*  production plan issue with sales order (backport [#39901](#39901)) ([#39904](#39904)) ([88a7248](88a7248))
* add permissions to SRE (backport [#39780](#39780)) ([#39786](#39786)) ([ba05648](ba05648))
* Brazilian COA for demo data creation ([#39839](#39839)) ([4daee6d](4daee6d))
* calculate `stock_value_diff` ([5a66c85](5a66c85))
* create SBB for `transfer_qty` in SE (backport [#39835](#39835)) ([#39863](#39863)) ([92e6017](92e6017))
* do not consider rejected warehouses in pick list (backport [#39539](#39539)) (backport [#39804](#39804)) ([#39811](#39811)) ([30dacce](30dacce))
* incorrect planned qty in PP (backport [#39785](#39785)) ([#39793](#39793)) ([60e04ab](60e04ab))
* landed cost voucher not submitting because of incorrect reference (backport [#39898](#39898)) ([#39900](#39900)) ([a548f12](a548f12))
* remove duplicates from tax category map ([3c6114a](3c6114a))
* set rate for PO created against BO (backport [#39765](#39765)) ([#39767](#39767)) ([2213886](2213886))
* stock entry for use serial batch fields (backport [#39843](#39843)) ([#39844](#39844)) ([43fce29](43fce29))
* use correct field name in accounts controller (backport [#39884](#39884)) ([#39897](#39897)) ([f08b424](f08b424))
* **ux:** set rate as price list rate on uom change in MR (backport [#39816](#39816)) ([#39818](#39818)) ([63b4d20](63b4d20))
* validate duplicate SBB (backport [#39862](#39862)) ([#39866](#39866)) ([a2f1a96](a2f1a96))
* warehouse issue in pick list (backport [#39826](#39826)) ([#39827](#39827)) ([b625b05](b625b05))

### Features

* get RM costs from consumption entry in manufacture SE (backport [#39822](#39822)) ([#39847](#39847)) ([2d5f186](2d5f186))

### Performance Improvements

* cached get_last_purchase_details to fix performance issue (backport [#39854](#39854)) ([#39856](#39856)) ([c643e70](c643e70))
* production plan submission (backport [#39846](#39846)) ([#39860](#39860)) ([10f17df](10f17df))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants