Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch company terms #39857

Merged
merged 3 commits into from
Feb 13, 2024
Merged

fix: fetch company terms #39857

merged 3 commits into from
Feb 13, 2024

Conversation

kunhimohamed
Copy link
Contributor

System does not fetch the Company terms at Sales Invoicing.

barredterra
barredterra reviewed Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@barredterra barredterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The get_party_account section (lines 21–34) seems to be redundant and could be removed, right?

@barredterra barredterra added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Feb 13, 2024
@barredterra barredterra self-assigned this Feb 13, 2024
@barredterra barredterra merged commit 24ba26f into frappe:develop Feb 13, 2024
11 checks passed
@kunhimohamed kunhimohamed deleted the company_terms branch February 14, 2024 06:46
@kunhimohamed kunhimohamed restored the company_terms branch February 14, 2024 11:35
@kunhimohamed kunhimohamed deleted the company_terms branch February 14, 2024 11:41
@kunhimohamed
Copy link
Contributor Author

the same issue happens in version-14 also.

This was referenced Feb 14, 2024
Merged
Merged
barredterra added a commit that referenced this pull request Feb 17, 2024
@barredterra
Merge pull request #39907 from frappe/mergify/bp/version-15-hotfix/pr…
0b7a953 
…-39857

fix: fetch company terms (backport #39857)
barredterra added a commit that referenced this pull request Feb 17, 2024
@barredterra
Merge pull request #39906 from frappe/mergify/bp/version-14-hotfix/pr…
a83ce43 
…-39857

fix: fetch company terms (backport #39857)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barredterra barredterra barredterra approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees

@barredterra barredterra

Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunhimohamed @barredterra