fix: reposting failed status not updated #39970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the reposting failed because of Accounting Period validation or any other validation then status was remaining as "In Progress" and not failed. User has to check the scheduled job log to check the error which is difficult for the non devs to understand.
Issue
The status was not updating because the frappe.message_log returns the dict in v15 where as it returns the string in the v14
After Fix
The status has changed to Failed for the repost item valuation with error log