fix: reconciled advance payment shows up in reconciliation tool under invoices

[ruthra-kumar]

Issue

1. Enable Book Advance Payments in Separate Party Account
2. Make Purchase Order
3. Make Payment against Purchase Order
4. Make Purchase Invoice for Purchase Order and reconcile advance against this invoice using Reconciliation tool

Advance Payment shows up under 'Invoices' section in Payment Reconciliation tool.

Root cause

GL entries for Advance payment

Account	Debit	Credit	Voucher No	Against Voucher
Advance Paid	1000	0	ACC-PAY-2024-00012	PUR-ORD-2024-0001
Cash	0	1000	ACC-PAY-2024-00012

against_voucher field is referring Purchase Order.

Upon reconciliation

Account	Debit	Credit	Voucher No	Against Voucher	-
Advance Paid	1000	0	ACC-PAY-2024-00012	PUR-ORD-2024-0001	<-
Cash	0	1000	ACC-PAY-2024-00012
Advance Paid	0	1000	ACC-PAY-2024-00012	ACC-PAY-2024-00012	<-
Creditors	1000	0	ACC-PAY-2024-00012	ACC-PINV-2024-00055

For Advance Paid account, Against Voucher is still referencing Purchase Order. This cause it to be incorrectly identified as an Invoice.

For a normal Payment, since the amount stays within the same account, this wasn't an issue. But for Advance Payments (Book Advance Payments in Separate Party Account), amount moves from one account to another upon reconciliation. But, during this original two rows are untouched.

Fix

For Payment Entries, don't post references to Sales / Purchase Order in Ledger, as they anyways have no impact on Ledger.

Todo

• Calculate Advance Paid for Sales / Purchase Order directly from Payment Entry References or Journal references
• Test Cases for Journal / Payment with references to multiple SO / PO
• Test Unreconciliation on [2]
• Test Unreconciliation on [2] along with Advance as a Liability enabled.

[ruthra-kumar]

Abandoning this in favor of #43627