Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not include advances for tds vouchers #43397

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

ljain112
Copy link
Contributor

Issue: TDS is getting deducted even though the threshold has not been breached.

Steps To Replicate:

  • Create a Journal Entry for the supplier by debiting the supplier account and crediting tds account.
  • Now create a purchase invoice with apply_tds enabled and tds_category.
  • TDS will get deducted even though the threshold has not been breached.

Solution:
Only include vouchers with the same tax_withholding_category for checking if tds is deducted earlier.

Notes :

  • Since we are already checking for payment entry separately advances will be checked automatically.
  • Advances are still required for TCS(sales workflow) because tax_withholding_category field is not present in sales invoice.

Frappe Support Issue: https://support.frappe.io/helpdesk/tickets/17255

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 26, 2024
@vorasmit vorasmit merged commit 6909d27 into frappe:develop Oct 8, 2024
14 checks passed
vorasmit added a commit that referenced this pull request Oct 8, 2024
…-43397

fix: do not include advances for tds vouchers (backport #43397)
vorasmit added a commit that referenced this pull request Oct 8, 2024
…-43397

fix: do not include advances for tds vouchers (backport #43397)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants