fix: delete invalid pricing rule on change of applicable_for values #43557
+66
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljain112
changed the title
ljain112
force-pushed
the
fix-promo-scheme
branch
2 times, most recently
from
4e864a3
to
4de2262
Compare
ljain112
force-pushed
the
fix-promo-scheme
branch
from
4de2262
to
2613bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
On change of applicable_for_values Pricing Rules are not deleted.
Steps to replicate:
The pricing rule still exists for both of the customers.
Closes: #43456
Frappe Support: https://support.frappe.io/app/hd-ticket/22927
backport version-15-hotfix
backport version-14-hotfix