Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation for corrective job card (backport #43555) (backport #43558) #43628

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 12, 2024

Issue

While completing the corrective job card, system throwing the below error

Screenshot 2024-10-08 at 12 10 02 PM
This is an automatic backport of pull request #43555 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #43558 done by [Mergify](https://mergify.com).

* fix: validation for corrective job card (#43555)

(cherry picked from commit 7a0a893)

# Conflicts:
#	erpnext/manufacturing/doctype/job_card/job_card.py

* chore: fix conflicts

* chore: fix linters issue

---------

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
(cherry picked from commit cf0fa0d)
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 12, 2024
@rohitwaghchaure rohitwaghchaure merged commit 1f09975 into version-14-hotfix Oct 12, 2024
11 checks passed
@rohitwaghchaure rohitwaghchaure deleted the mergify/bp/version-14-hotfix/pr-43558 branch October 12, 2024 13:02
@rohitwaghchaure
Copy link
Collaborator

@Mergifyio backport version-14

Copy link
Contributor Author

mergify bot commented Oct 12, 2024

backport version-14

✅ Backports have been created

mergify bot added a commit that referenced this pull request Oct 12, 2024
…43558) (#43628)

fix: validation for corrective job card (backport #43555) (#43558)

* fix: validation for corrective job card (#43555)

(cherry picked from commit 7a0a893)

# Conflicts:
#	erpnext/manufacturing/doctype/job_card/job_card.py

* chore: fix conflicts

* chore: fix linters issue

---------

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
(cherry picked from commit cf0fa0d)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 1f09975)
rohitwaghchaure added a commit that referenced this pull request Oct 12, 2024
fix: validation for corrective job card (backport #43555) (backport #43558) (backport #43628)
frappe-pr-bot pushed a commit that referenced this pull request Oct 12, 2024
## [14.74.5](v14.74.4...v14.74.5) (2024-10-12)

### Bug Fixes

* validation for corrective job card (backport [#43555](#43555)) (backport [#43558](#43558)) ([#43628](#43628)) ([ea0f044](ea0f044))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant