Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add flags, validations, error messages #1430

Merged
merged 7 commits into from
Feb 20, 2024
Merged

fix: add flags, validations, error messages #1430

merged 7 commits into from
Feb 20, 2024

Conversation

18alantom
Copy link
Member

@18alantom 18alantom commented Feb 9, 2024

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c865255) 45.25% compared to head (5992e0f) 45.29%.
Report is 4 commits behind head on master.

❗ Current head 5992e0f differs from pull request most recent head 7e4fea1. Consider uploading reports for the commit 7e4fea1 to get more accurate results

Files Patch % Lines
press/press/doctype/release_group/release_group.py 69.56% 7 Missing ⚠️
press/press/doctype/agent_job/agent_job.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
+ Coverage   45.25%   45.29%   +0.03%     
==========================================
  Files         312      312              
  Lines       20966    20987      +21     
==========================================
+ Hits         9489     9506      +17     
- Misses      11477    11481       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@18alantom 18alantom marked this pull request as ready for review February 20, 2024 05:09
@18alantom
Copy link
Member Author

Merging. Failing Server (1) is due to no space left in GActions Cache. Ignoring CodeCov.

@18alantom 18alantom merged commit 57759ba into master Feb 20, 2024
4 of 5 checks passed
@18alantom 18alantom deleted the minor-changes branch February 20, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant