Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors aren’t reported correctly in Chrome if webextension-polyfill is used #16

Closed
fregante opened this issue Jan 23, 2021 · 0 comments
Closed

Errors aren’t reported correctly in Chrome if webextension-polyfill is used #16

fregante opened this issue Jan 23, 2021 · 0 comments
Labels
bug good first issue help wanted

Comments

@fregante
Copy link
Owner

Due to mozilla/webextension-polyfill#257

Must be fixed locally before releasing v2:

error instanceof Error ? error : new Error(error.message)
@fregante fregante changed the title Errors aren’t reported correctly in Chrome if webextensions-polyfill is used Errors aren’t reported correctly in Chrome if webextension-polyfill is used Jan 23, 2021
fregante added a commit to fregante/webext-polyfill-kinda that referenced this issue Jan 23, 2021
@fregante
Reject with a real Error
dcbb774 
Partial solution for fregante/webext-permission-toggle#16
fregante added a commit that referenced this issue Jan 23, 2021
@fregante
Correctly report errors in Chrome
c2743d1 
Fixes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fregante