Allow optionally forcing power requests #365
Merged
Commits on May 25, 2023
-
Fix wrong documentation in tests
Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
-
Use future annotations in power distribution tests
Future annotations is already imported and it should be used instead. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
-
Test all batteries are used if none of them works
A test was not added when the power distributing actor was updated in the past to use all the batteries for cases where all of them are reported as not working batteries. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
-
Amend existent power distributing test
To make it consistent with recently added power distributing tests. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
-
Simplify working batteries check
The _get_working_batteries method had unnecessary complexity and was redundant as it was returning the original set of batteries if there was any working battery. Therefore, this commit removes the _get_working_batteries method and simplifies the check for working batteries. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
-
Add battery request check for empty set
Requests with empty batteries set need to be rejected. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
-
Allow optionally forcing power requests
A power request might need to be forced to implement safety mechanisms, even when some components might be seemingly failing (i.e. when there is not proper consumption information, the user wants to slowly discharge batteries to prevent potential peak breaches). Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.