🐛 Prevent handlebar to compile template if content is empty (#156)

frinyvonnick · Feb 8, 2022 · 2684645 · 2684645
1 parent d28d88e
commit 2684645
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 1 deletion.
diff --git a/src/models/Screenshot.spec.ts b/src/models/Screenshot.spec.ts
@@ -112,6 +112,15 @@ describe("Screenshot", () => {
     expect(screenshot.quality).toEqual(undefined);
   });
 
+  it("should handle empty content", () => {
+    const screenshot = new Screenshot({
+      html,
+      content: {},
+    });
+
+    expect(screenshot.content).toEqual(undefined);
+  });
+
   it("should set quality if type is jpeg", () => {
     const screenshot = new Screenshot({
       html,

diff --git a/src/models/Screenshot.ts b/src/models/Screenshot.ts
@@ -32,7 +32,7 @@ export class Screenshot {
     this.transparent = transparent;
     this.type = type;
     this.output = output;
-    this.content = content;
+    this.content = isEmpty(content) ? undefined : content;
     this.selector = selector;
     this.quality = type === "jpeg" ? quality : undefined;
   }
@@ -48,3 +48,7 @@ export class Screenshot {
     this.buffer = buffer;
   }
 }
+
+function isEmpty(val: object) {
+  return val == null || !Object.keys(val).length;
+}
diff --git a/src/screenshot.spec.ts b/src/screenshot.spec.ts
@@ -49,6 +49,20 @@ describe("beforeScreenshot", () => {
     );
   });
 
+  it("should not compile a screenshot if content is empty", async () => {
+    await makeScreenshot(page, {
+      screenshot: new Screenshot({
+        html: "<html><body>{{message}}</body></html>",
+        content: {},
+      }),
+    });
+
+    expect(page.setContent).toHaveBeenCalledWith(
+      "<html><body>{{message}}</body></html>",
+      expect.anything()
+    );
+  });
+
   it("should wait until load event", async () => {
     await makeScreenshot(page, {
       screenshot: new Screenshot({