Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render specified element #78

Closed

Conversation

SilveryStar
Copy link

Add feature: use the element option to specify the element to generate an image (can be used with content)

@SilveryStar
Copy link
Author

@frinyvonnick There was an error in my pull requests during Run yarn test.

FAIL src/index.spec.js (23.261 s)
  ● node-html-to-image › batch › should create two images
    ENOENT: no such file or directory, open './generated/image1.png'
  ● node-html-to-image › batch › should return two buffe

I think the reason lies in the test data, because the new option element cannot be empty in content (like output)

@frinyvonnick
Copy link
Owner

Hi @SilveryStar 👋

Thank you for opening this pull request 🙏 Sorry for the late response I was in holidays then started a new job so I didn't have a lot of time. I'll give it a look as soon as possible 👍

@frinyvonnick
Copy link
Owner

@SilveryStar a pull request that passes tests has been opened #87 but It lacks documentation and the one you did here looks really great. Maybe you can merge both work?

@frinyvonnick
Copy link
Owner

Done in #114

@frinyvonnick
Copy link
Owner

This was released in v3.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants