Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have the template specify more precise versions, as well as only refe… #104

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

baronfel
Copy link
Contributor

Change the paket.template to specify only the runtime references as you suggested. I can verify that this makes the IDE experience work!

image

@baronfel
Copy link
Contributor Author

@sergey-tihon to test this I packaged locally with a new version number, pushed to my local nuget cache, and updated your sample project. Then I opened that project in the IDE and boom it all worked.

@baronfel
Copy link
Contributor Author

nuspec ends up looking like this:

<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<package xmlns="http://schemas.microsoft.com/packaging/2011/10/nuspec.xsd">
  <metadata>
    <id>SwaggerProvider</id>
    <version>0.10.0-beta03</version>
    <title>Swagger Provider</title>
    <authors>Sergey Tihon</authors>
    <owners>Sergey Tihon</owners>
    <licenseUrl>http://github.com/fsprojects/SwaggerProvider/blob/master/LICENSE.txt</licenseUrl>
    <projectUrl>http://fsprojects.github.io/SwaggerProvider/</projectUrl>
  <iconUrl>https://raw.githubusercontent.com/fsprojects/SwaggerProvider/master/docs/files/img/logo.png</iconUrl>
    <description>F# Type Provider for Swagger</description>
    <summary>F# Type Provider for Swagger</summary>
    <copyright>Copyright 2015-2018</copyright>
    <tags>F# fsharp data typeprovider Swagger API REST OpenAPI</tags>
    <references>
      <reference file="SwaggerProvider.dll" />
      <reference file="SwaggerProvider.Runtime.dll" />
    </references>
    <dependencies>
      <dependency id="FSharp.Core" version="[4.0.0.1,4.0.1.0)" />
      <dependency id="Newtonsoft.Json" version="[10.0.3,10.1.0)" />
      <dependency id="YamlDotNet" version="[4.3.0,5.0.0)" />
    </dependencies>
  </metadata>
</package>

@sergey-tihon sergey-tihon merged commit a492ce1 into fsprojects:dev Feb 13, 2018
@sergey-tihon
Copy link
Member

Unbelievable! I did remove reference to *.DesignTime.dll manually from the project and it did not fix my local behavior...

@baronfel
Copy link
Contributor Author

Well the real test will be in ~1/2 hour when this package gets built and we can test the full setup on your sample project :) I'm so glad it's seemingly just a simple config problem rather than a core code problem.

@baronfel
Copy link
Contributor Author

Also see how I snuck in the version-pinning changes :D I'm sly like that.

@sergey-tihon
Copy link
Member

Thank you, but I will revert the line

FSharp.Core ~> LOCKEDVERSION

because

<dependency id="FSharp.Core" version="[4.0.0.1,4.0.1.0)" />

looks incorrect, it shluld work with latest 4.3.* package ...

@baronfel
Copy link
Contributor Author

Then we should update what's in our paket.dependency as well, so they are always in-sync.

@baronfel
Copy link
Contributor Author

wait, I see what you mean. I wonder if there's a way to pull that entire expression from the paket.dependencies....

@baronfel
Copy link
Contributor Author

It looks like it's possible to not have to duplicate the version constraints, but only if your paket.template is of type project, which ours it not. Oh well 🤷‍♂️

@baronfel
Copy link
Contributor Author

works like a charm with the real nuget package, BTW :)

@sergey-tihon
Copy link
Member

sergey-tihon commented Feb 13, 2018

Thank you for help @baronfel. It really looks like a fix - you rocks!

I'll try and push the following template with SDK update (when it will be fixed, current master is broken)

dependencies
    FSharp.Core >= LOCKEDVERSION
    Newtonsoft.Json ~> LOCKEDVERSION
    YamlDotNet ~> LOCKEDVERSION

should be close to what we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants