Slovenian Fakers #363
Slovenian Fakers #363
Conversation
Slovenian fakers for Address, Internet, Payment, Person and PhoneNumber.
| protected static $buildingNumber = array('1##', '##', '##', '##', '##', '#'); | ||
| // protected static $streetSuffix = array(); | ||
| protected static $postcode = array('###0'); | ||
| protected static $streetNameFormats = array( |
There was a problem hiding this comment.
this variable shouldn't be named formats, as it's an array of street names, not a formaT.
also, could you add a link to the data source in the code comments?
+ added links to data sources + alphabetically sorted cities + renamed variables
| ); | ||
|
|
||
| protected static $buildingNumber = array('1##', '##', '##', '##', '##', '#'); | ||
| // protected static $streetSuffix = array(); |
There was a problem hiding this comment.
please don't commit commented out code
- removed new lines from comments and variables. - removed commented lines - added new line between variables
|
Surprisingly, after having git-cloned Any Travis-CI trouble may be involved here ? Maybe @alesf shall try a new test commit to force Travis-ci to check this PR again ? |
Forcing Travis CI to recheck this repo again.
|
@ronanguilloux You were right. Travis-CI was apparently acting out. I committed again and now this build passed. |
|
|
| * {@link} http://www.stat.si/imena_top_imena_spol.asp?r=True | ||
| * {@link} http://www.stat.si/doc/vsebina/05/imena/TOPIMENA_SI.xlsx | ||
| */ | ||
| protected static $firstNameMale = array( |
There was a problem hiding this comment.
Can you please sort this list, as well as all the other lists, in alphabetical order?
- lists in alphabetical order - fixed phpDoc syntax - removed a suffix function that returned nothing - removed functions for male and female titles as they returned same results
- The closing brace for the class must go on the next line after the body
|
Thanks! |
No description provided.