Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

en_GB people provider #421

Merged
merged 2 commits into from Jan 4, 2015
Merged

en_GB people provider #421

merged 2 commits into from Jan 4, 2015

Conversation

alexcutts2
Copy link
Contributor

I've recently found myself using Faker for some test data to provide a demonstration system and found that the names which were being generated in most cases, weren't names which are commonly used in the UK.

I've created a simple Person class for the UK.

Data for forenames came from ONS female names here and male names here - I used the data from 2003 and 2013.

I also used some of the names already in the en_US locale which were relevant to a UK audience.

For surnames, I found a list here which seemed to reflect usage well.

I haven't added any tests as I've only changed the contents of the arrays, but if there's anything else I should be doing let me know. I've not made an open source contribution before, and I wasn't entirely sure if I should be submitting this as none of the other EN locales have specific Person providers (other than the default en_GB).

Add a more specific faker provider for UK names
'{{firstNameFemale}} {{lastName}}',
);

protected static $firstNameMale = array(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reference the data source in a phpDoc @link comment

fzaninotto added a commit that referenced this pull request Jan 4, 2015
@fzaninotto fzaninotto merged commit fceaaf3 into fzaninotto:master Jan 4, 2015
@fzaninotto
Copy link
Owner

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants