This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
min / max for lat long values #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes you may want to set lat/lng parameters for a spesific area. Ex: For Istanbul: 'lat' => $faker->latitude(40.958836, 41.136456), 'lng' => $faker->longitude(28.64, 29.98),
| * @example 77.147489 | ||
| * @return float Uses signed degrees format (returns a float number between -90 and 90) | ||
| * @example '77.147489' | ||
| * @param int $min |
There was a problem hiding this comment.
it's a float, not an int, right?
There was a problem hiding this comment.
Sorry for missing that, Phpstorm decided it, not me :)
|
Please also update the README to add an example with the new parameter |
| { | ||
| return static::randomFloat(6, 0, 180) - 90; | ||
| return floatval(number_format(mt_rand($min * 1000000, $max * 1000000)/1000000, 6)); |
There was a problem hiding this comment.
I don't understand the interest of converting a float to string (with number_format) and then back to float (with floatval)
|
Tests fail |
|
Also, please see #416 for why you should use |
|
@fzaninotto @actuallymab Any update on this PR?. we are really interested in this feature |
|
don't know.. @fzaninotto ok with this? |
| * @return float Uses signed degrees format (returns a float number between -90 and 90) | ||
| */ | ||
| public static function latitude() | ||
| public static function latitude($min = -90, $max = 90) |
There was a problem hiding this comment.
You're changing the results of existing calls. Please use 0 and 180 as min and max values.
fzaninotto
added a commit
that referenced
this pull request
Feb 23, 2016
min / max for lat long values
|
Thanks |
fzaninotto
added a commit
that referenced
this pull request
Feb 23, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you may want to set lat/lng parameters for a spesific area.
Ex:
For Istanbul:
'lat' => $faker->latitude(40.958836, 41.136456),
'lng' => $faker->longitude(28.64, 29.98),