This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
US phone numbers #615
Merged
US phone numbers #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,8 +9,8 @@ class PhoneNumber extends \Faker\Provider\Base | |||
| /** | |||
| * @example '555-123-546' | |||
| */ | |||
| public static function phoneNumber() | |||
| public function phoneNumber() | |||
There was a problem hiding this comment.
This will break many locales overriding this method with a static one. If you change it here, you must change it in locales, too.
There was a problem hiding this comment.
Sorry, I just saw that you actually did that further down in the PR ;)
|
Good PR, needs a few tweaks but definitely worth merging! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the rules for the North American Numbering Plan (NANP). It does not generate numbers including so-called "easily recognizable codes" which are used for various special services and not assigned to geographic regions, for example 911 (emergency), 411 (directory), 511 (traffic information) or 800 (toll-free).
Toll-free numbers can be generated with
tollFreePhoneNumber().Fixes #588