This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Optimize Internet::toAscii() by using a static cache #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, looking at code before #333, it seems this method shouldn't be public. |
| 'ս' => 's','վ' => 'v','տ' => 't','ր' => 'r','ց' => 'ts','փ' => 'p', | ||
| 'ք' => 'q','և' => 'ev','օ' => 'o','ֆ' => 'f', | ||
| ); | ||
| static $arrayFrom, $arrayTo; |
There was a problem hiding this comment.
please don't define multiple variables on one line
There was a problem hiding this comment.
oh, wait, ignore me - i thought this was on a different repo...
fzaninotto
added a commit
that referenced
this pull request
Oct 4, 2015
Optimize Internet::toAscii() by using a static cache
|
Great, thanks! |
|
So, Also, |
|
Agreed on both propositions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes quite a difference, even the
$transliterationTablearray creation is costly.No possible drawback as it is contained inside the method.