This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Italian Vat id and Tax id support #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public function testIfTaxIdCanReturnData() | ||
| { | ||
| $vatId = $this->faker->vatId(); | ||
| $this->assertRegExp('/^IT{12}[0-9]$/', $vatId); |
There was a problem hiding this comment.
I don't know exactly how the regexify method works, but doesn't this match only ITTTTTTTTTTTT[0-9]?
Sorry if I'm missing something.
There was a problem hiding this comment.
Ops it is a mistake i fix it now!
Tnks
|
I fixed the mistake |
| */ | ||
| public static function vatId() | ||
| { | ||
| return static::regexify('/^IT[0-9]{12}$/'); |
There was a problem hiding this comment.
Quoting from https://en.wikipedia.org/wiki/VAT_identification_number :
11 digits (the first 7 digits is a progressive number, the following 3 means the province of residence, the last digit is a check number)
| */ | ||
| public static function vatId() | ||
| { | ||
| return static::regexify('/^IT[0-9]{11}$/'); |
There was a problem hiding this comment.
regexify is very slow, use numerify instead.
|
You should add a mention of the new providers in the Readme, under the "Locales" section. |
|
Travis fail in HHVM build |
fzaninotto
added a commit
that referenced
this pull request
Feb 9, 2016
Italian Vat id and Tax id support
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Italian TaxId (Codice fiscale) https://it.wikipedia.org/wiki/Codice_fiscale
Italian VatId (Partita iva) https://it.wikipedia.org/wiki/Partita_iva