This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Update Image.php #963
Merged
Update Image.php #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any feedback on this? |
|
Thanks! |
| $success = curl_exec($ch) || curl_getinfo($ch, CURLINFO_HTTP_CODE) === 200; | ||
|
|
||
| if ($success){ | ||
| fclose($fp); |
There was a problem hiding this comment.
Shouldn't this happen regardless of success?
| curl_close($ch); | ||
| fclose($fp); | ||
| } elseif (ini_get('allow_url_fopen')) { |
There was a problem hiding this comment.
Shouldn't the same checks go here in case curl isn't enabled?
if lorempixel is not available then the image is saved as spoiled, 0 kb, so there is no need to store it |
|
Yeah, I get that much. But if I expect all my images to be generated, some are inexplicably missing, and I'm not versed in the intricacies of this issue, what do I do? |
|
in my opinion its a good catch to add additional check in your code |
|
But once again, if I'm a user who has no idea this is an issue, how would I know to do that? I certainly don't do anything like: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix broken image if service unavailable