Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename BSX to UNITS #196

Merged
merged 4 commits into from
Oct 15, 2021
Merged

refactor: rename BSX to UNITS #196

merged 4 commits into from
Oct 15, 2021

Conversation

Roznovjak
Copy link
Collaborator

Fixes: #158

@codecov
Copy link

codecov bot commented Oct 14, 2021 •
edited
Loading

Codecov Report

Merging #196 (a55ba56) into master (13b404f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files          21       21           
  Lines        2132     2132           
=======================================
  Hits         1817     1817           
  Misses        315      315

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b404f...a55ba56. Read the comment docs.

jak-pan
jak-pan approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@jak-pan jak-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to handle the decimals in some better way but I agree this is much better and I don't have a better solution than this.

@Roznovjak Roznovjak merged commit ae46540 into master Oct 15, 2021
@Roznovjak Roznovjak deleted the refactor/rename_BSX_to_UNITS branch October 15, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jak-pan jak-pan jak-pan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename BSX to UNITS
2 participants
@Roznovjak @jak-pan