Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: AssetPairAccountId trait #237

Merged
merged 3 commits into from
Nov 15, 2021
Merged

Conversation

Roznovjak
Copy link
Collaborator

Fixes #129

Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one suggestion

primitives/src/traits.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #237 (272d934) into master (0240319) will increase coverage by 0.69%.
The diff coverage is 84.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   83.08%   83.77%   +0.69%     
==========================================
  Files          23       23              
  Lines        2152     2139      -13     
==========================================
+ Hits         1788     1792       +4     
+ Misses        364      347      -17     
Impacted Files Coverage Δ
pallets/exchange/src/lib.rs 78.66% <ø> (ø)
primitives/src/traits.rs 71.42% <ø> (ø)
pallets/exchange/src/direct.rs 85.88% <81.25%> (ø)
pallets/duster/src/lib.rs 81.03% <100.00%> (ø)
pallets/lbp/src/benchmarking.rs 98.66% <100.00%> (ø)
pallets/lbp/src/lib.rs 89.29% <100.00%> (+2.41%) ⬆️
pallets/xyk/src/lib.rs 84.16% <100.00%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d57ff1...272d934. Read the comment docs.

Co-authored-by: Martin Hloska <martin.hloska@gmail.com>
@mrq1911
Copy link
Member

mrq1911 commented Nov 15, 2021

LGTM after build passes

@Roznovjak Roznovjak merged commit 5cc5348 into master Nov 15, 2021
@enthusiastmartin enthusiastmartin deleted the refactor/asset_pair_account_id branch November 15, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: remove AssetPairAccountId from pallet config
3 participants