Set fullProjectPath variable in entrypoint.sh #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
falko17
changed the title
webbertakken
approved these changes
Dec 24, 2023
This should catch bugs like the one described in game-ci#255.
falko17
force-pushed
the
255-set-fullprojectpath
branch
from
dba7ec9
to
0bb2d85
Compare
AndrewKahr
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes the bug described in #255, i.e., it correctly sets the
fullProjectPathvariable inentrypoint.sh(the same way as it's done in https://github.com/game-ci/unity-builder).This also adds a test that runs edit mode tests1 as the host user, which should hopefully catch issues like these.
Related Issues
Successful Workflow Run Link
Checklist
Docs (not applicable)Readme (not applicable)Footnotes
I have only done this for edit tests, as the type of test (or the platform) should not be affected by the choice to run this as the host user, and I did not want to double the number of tests. ↩