Completely remove popover from ItemName (#700)

gbv · Mar 31, 2023 · 685cb1c · 685cb1c
1 parent 3ecee2f
commit 685cb1c
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 68 deletions.
diff --git a/src/components/ItemName.vue b/src/components/ItemName.vue
@@ -10,14 +10,6 @@
     <div
       :is="isValidLink ? 'router-link' : 'div'"
       :id="tooltipDOMID"
-      v-b-popover="_showPopover ? {
-        placement: 'top',
-        trigger: 'hover',
-        content: `${popoverHTML}`,
-        html: true,
-        boundary: 'window',
-        delay: defaults.delay.long,
-      } : null"
       :to="url"
       class="itemName-inner"
       :class="[
@@ -51,21 +43,6 @@
       class="missingDataIndicator">
       •
     </div>
-    <!-- Content for popover -->
-    <div
-      v-if="_showPopover && isHoveredFromHere"
-      :id="tooltipDOMID + '-contentMap'"
-      style="display: none">
-      <div style="max-height: 400px; overflow: auto;">
-        <!-- Ancestors / Broader -->
-        <concept-detail-ancestors
-          :item="item"
-          :is-left="isLeft"
-          :allow-show-ancestors="false"
-          style="margin-bottom: 5px;" />
-        <content-map :content-map="contentMap" />
-      </div>
-    </div>
   </div>
 </template>
 
@@ -74,16 +51,12 @@ import _ from "lodash"
 import dragandrop from "@/mixins/dragandrop.js"
 import { getItem } from "@/items"
 
-import ContentMap from "./ContentMap.vue"
-import ConceptDetailAncestors from "./ConceptDetailAncestors.vue"
-import { mainLanguagesContentMapForConcept } from "@/utils/concept-helpers"
 
 /**
  * Component that displays an item's notation (if defined) and prefLabel.
  */
 export default {
   name: "ItemName",
-  components: { ContentMap, ConceptDetailAncestors },
   mixins: [dragandrop],
   props: {
     /**
@@ -128,13 +101,6 @@ export default {
       type: Boolean,
       default: true,
     },
-    /**
-     * Determines whether to show some concept details as a popover.
-     */
-    showPopover: {
-      type: Boolean,
-      default: false,
-    },
     /**
      * Determines whether the item is highlighted
      */
@@ -174,8 +140,6 @@ export default {
       url: "",
       isValidLink: false,
       interval: null,
-      // We are using this inside a v-b-popover directive. To have up-to-date data, it is set on hover.
-      popoverHTML: "",
     }
   },
   computed: {
@@ -201,25 +165,6 @@ export default {
     isScheme() {
       return this.$jskos.isScheme(this._item)
     },
-    // Content for popover with ContentMap component
-    contentMap() {
-      const contentMap = mainLanguagesContentMapForConcept(this._item)
-      Object.values(contentMap).filter(map => map.props.includes("prefLabel")).forEach(map => {
-        map.classes = "fontWeight-heavy"
-      })
-      return contentMap
-    },
-    _showPopover() {
-      return this.showPopover && (!this.showText || !this._showNotation || Object.values(this.contentMap).length)
-    },
-  },
-  watch: {
-    _item() {
-      if (this.popoverHTML) {
-        // When item is updated and popoverHTML is set, update it
-        this.updatePopoverHTML()
-      }
-    },
   },
   created() {
     this.hovering = _.debounce(this._hovering, 20)
@@ -250,8 +195,6 @@ export default {
             window.clearInterval(this.interval)
           }
         }, 500)
-        // Set popover HTML
-        this.updatePopoverHTML()
       } else {
         this.isHoveredFromHere = false
         this.$store.commit({
@@ -261,11 +204,6 @@ export default {
         window.clearInterval(this.interval)
       }
     },
-    updatePopoverHTML() {
-      this._showPopover && this.$nextTick(() => {
-        this.popoverHTML = document.getElementById(this.tooltipDOMID + "-contentMap").innerHTML
-      })
-    },
   },
 }
 

diff --git a/src/components/MappingBrowserTable.vue b/src/components/MappingBrowserTable.vue
@@ -41,7 +41,6 @@
             v-if="!$jskos.isContainedIn(concept, loadingConcepts)"
             :item="concept"
             :show-text="false"
-            :show-popover="true"
             :is-link="true"
             :is-left="true"
             :is-highlighted="$jskos.compare(concept, selected.concept[true]) || $jskos.compare(concept, selected.concept[false])" />
@@ -66,7 +65,6 @@
             v-if="!$jskos.isContainedIn(concept, loadingConcepts)"
             :item="concept"
             :show-text="true"
-            :show-popover="true"
             :is-link="true"
             :is-left="true"
             :is-highlighted="$jskos.compare(concept, selected.concept[true]) || $jskos.compare(concept, selected.concept[false])" />
@@ -113,7 +111,6 @@
             <item-name
               :item="concept"
               :show-text="false"
-              :show-popover="true"
               :is-link="true"
               :is-left="false"
               :is-highlighted="$jskos.compare(concept, selected.concept[false]) || $jskos.compare(concept, selected.concept[true])" /><br>
@@ -139,7 +136,6 @@
             <item-name
               :item="concept"
               :show-text="true"
-              :show-popover="true"
               :is-link="true"
               :is-left="false"
               :is-highlighted="$jskos.compare(concept, selected.concept[false]) || $jskos.compare(concept, selected.concept[true])" /><br>

diff --git a/src/components/MappingEditor.vue b/src/components/MappingEditor.vue
@@ -136,7 +136,6 @@
                   :is-link="true"
                   :is-left="isLeft"
                   :is-highlighted="$jskos.compare(concept, selected.concept[true]) || $jskos.compare(concept, selected.concept[false])"
-                  :show-popover="true"
                   font-size="large" />
                 <!-- Delete button for concept -->
                 <span

diff --git a/src/components/TheNavbar.vue b/src/components/TheNavbar.vue
@@ -74,7 +74,6 @@
             icon: 'recycle'
           }]"
           :show-labels="true"
-          :show-popover="false"
           :show-registry="true"
           :hide-duplicates="false"
           style="width: 700px;"