TheSettings: Move About to footer and add GitHub link (#173)

gbv · Jan 4, 2019 · e689ddc · e689ddc
1 parent 4e87c33
commit e689ddc
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 33 deletions.
diff --git a/config/locale.json b/config/locale.json
@@ -107,7 +107,6 @@
       "tabLayout": "Layout",
       "tabSources": "Data Sources",
       "tabLocalMappings": "Local Mappings",
-      "tabAbout": "About",
       "showAllAncestors": "Always show all ancestors in concept details.",
       "truncateNotes": "Do not truncate notes in concept details.",
       "showAll": "Always show all mappings and suggestions in mapping browser.",
@@ -198,7 +197,6 @@
       "tabLayout": "Layout",
       "tabSources": "Datenquellen",
       "tabLocalMappings": "Lokale Mappings",
-      "tabAbout": "Über",
       "showAllAncestors": "Immer alle übergeordneten Konzepte anzeigen.",
       "truncateNotes": "Notizen für Konzepte nicht abschneiden.",
       "showAll": "Immer alle Mappings und Vorschläge anzeigen.",

diff --git a/src/components/TheSettings.vue b/src/components/TheSettings.vue
@@ -7,7 +7,8 @@
     centered
     size="lg" >
     <b-card
-      no-body>
+      no-body
+      footer-tag="footer">
       <b-tabs
         pills
         card
@@ -139,37 +140,47 @@
             </b-button>
           </p>
         </b-tab>
-        <b-tab
-          :title="$t('settings.tabAbout')" >
-          <p>
-            {{ $t("settings.suggestions1") }}
-            <a
-              href="https://github.com/gbv/cocoda/issues"
-              target="_blank" >{{ $t("settings.suggestions2") }}</a>{{ $t("settings.suggestions3") }}
-          </p>
-          <p v-if="config.buildInfo.gitTag && config.buildInfo.gitTag != ''">
-            {{ $t("settings.version") }}: {{ config.buildInfo.gitTag }}
-          </p>
-          <p v-if="config.buildInfo.gitCommit && config.buildInfo.gitCommitShort">
-            {{ $t("settings.currentCommit") }}:
-            <a
-              :href="'https://github.com/gbv/cocoda/commit/' + config.buildInfo.gitCommit"
-              target="_blank" >
-              {{ config.buildInfo.gitCommitShort }}
-            </a>
-          </p>
-          <p v-if="config.buildInfo.buildDate">
-            {{ $t("settings.buildDate") }}: {{ config.buildInfo.buildDate }}
-          </p>
-          <p v-if="config.impressumUrl">
-            <a
-              :href="config.impressumUrl"
-              target="_blank" >
-              {{ $t("settings.impressum") }}
-            </a>
-          </p>
-        </b-tab>
       </b-tabs>
+      <span slot="footer">
+        <a
+          href="https://github.com/gbv/cocoda"
+          target="_blank" >
+          <font-awesome-icon :icon="['fab', 'github']" />
+          GitHub
+        </a>
+        <span v-if="config.buildInfo.gitTag && config.buildInfo.gitTag != ''">
+          •
+          {{ $t("settings.version") }} {{ config.buildInfo.gitTag }}
+        </span>
+        <span v-if="config.buildInfo.gitCommit && config.buildInfo.gitCommitShort">
+          •
+          {{ $t("settings.currentCommit") }}:
+          <a
+            :href="'https://github.com/gbv/cocoda/commit/' + config.buildInfo.gitCommit"
+            target="_blank" >
+            {{ config.buildInfo.gitCommitShort }}
+          </a>
+        </span>
+        <span v-if="config.buildInfo.buildDate">
+          •
+          {{ $t("settings.buildDate") }}: {{ config.buildInfo.buildDate }}
+        </span>
+        <span v-if="config.impressumUrl">
+          •
+          <a
+            :href="config.impressumUrl"
+            target="_blank" >
+            {{ $t("settings.impressum") }}
+          </a>
+        </span>
+        <br>
+        <span>
+          {{ $t("settings.suggestions1") }}
+          <a
+            href="https://github.com/gbv/cocoda/issues"
+            target="_blank" >{{ $t("settings.suggestions2") }}</a>{{ $t("settings.suggestions3") }}
+        </span>
+      </span>
     </b-card>
 
   </b-modal>